struct logs: add raw key for JSON blobs #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds raw JSON logging support to structured logging by introducing a raw key that allows JSON objects to be embedded directly into log messages. The specific implementation adds FlexrayControllerConfig JSON serialization to message tracing.
- Adds new
rawkey to structured logging keys - Implements JSON serialization for FlexrayControllerConfig in message tracing
- Updates logging infrastructure to handle raw JSON values without double-escaping
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| SilKit/source/services/logging/StructuredLoggingKeys.hpp | Adds new raw key and converts string keys to string_view for performance |
| SilKit/source/services/logging/SilKitFmtFormatters.hpp | Removes trailing empty line |
| SilKit/source/services/logging/MessageTracing.hpp | Adds YamlParser include and FlexrayControllerConfig JSON serialization to trace functions |
| SilKit/source/services/logging/Logger.cpp | Updates JSON formatting to handle raw key values without escaping |
| SilKit/source/core/internal/ServiceDescriptor.hpp | Updates return type to use string_view for key names |
| SilKit/source/config/YamlWriter.hpp | Adds FlexrayControllerConfig Write method declaration |
| SilKit/source/config/YamlWriter.cpp | Implements FlexrayControllerConfig Write method |
| SilKit/source/config/YamlParser.hpp | Adds include guard for Windows GetCurrentTime macro |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
KonradBreitsprecherBkd
requested changes
Oct 13, 2025
review feedback from konrad
remove unnecessary template and clean up #defines
SimplyLMK
pushed a commit
to SimplyLMK/sil-kit
that referenced
this pull request
Oct 23, 2025
The raw field in slogs allows us to add debugging information in JSON. In this case, add the FR ControllerConfig as a JSON object. Refactor the TraceTx/TraceRx to use less helper templates und use more constexpr-ifs. SILKIT-1827
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rawfield in slogs allows us to add debugging information in JSON.In this case, add the FR ControllerConfig as a JSON object.
SILKIT-1827